Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make debounce helpers to accept functions with arguments #3744

Closed
edloidas opened this issue Oct 8, 2024 · 0 comments · Fixed by #3745
Closed

Make debounce helpers to accept functions with arguments #3744

edloidas opened this issue Oct 8, 2024 · 0 comments · Fixed by #3745
Assignees
@edloidas
Labels
Bug Something isn't working

Comments

@edloidas
Copy link
Member

edloidas commented Oct 8, 2024

After refactoring, functions, that are passed to debounce helpers became () => void, which is a subset of Function, and does not cover functions, that return something, or can accept arguments.
@edloidas edloidas added the Bug Something isn't working label Oct 8, 2024
@edloidas edloidas self-assigned this Oct 8, 2024
edloidas added a commit that referenced this issue Oct 8, 2024
@edloidas
Make debounce helpers to accept functions with arguments #3744
1487814 
Replaced functions  inside debounce helpers with arrow functions.
Removed `args` declarations, used _anyArgs directly.
edloidas added a commit that referenced this issue Oct 8, 2024
@edloidas
Make debounce helpers to accept functions with arguments #3744
22067ff 
Fixed types.
Replaced functions inside debounce helpers with arrow functions.
Removed `args` declarations, used _anyArgs directly.
Added VSCode config for development.
@edloidas edloidas linked a pull request Oct 8, 2024 that will close this issue
Make debounce helpers to accept functions with arguments #3744 #3745
Merged
alansemenov pushed a commit that referenced this issue Oct 8, 2024
@edloidas @alansemenov
Make debounce helpers to accept functions with arguments #3744
2d82301 
Fixed types.
Replaced functions inside debounce helpers with arrow functions.
Removed `args` declarations, used _anyArgs directly.
Added VSCode config for development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edloidas edloidas

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make debounce helpers to accept functions with arguments #3744 enonic/lib-admin-ui
1 participant
@edloidas