Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseSelectedOptionView: typo in Edit button creation method #3555

Closed
ashklianko opened this issue May 6, 2024 · 0 comments · Fixed by #3556
Closed

BaseSelectedOptionView: typo in Edit button creation method #3555

ashklianko opened this issue May 6, 2024 · 0 comments · Fixed by #3556
Assignees
@ashklianko
Labels
Refactoring Code improvements

Comments

@ashklianko
Copy link
Member

createEditButton() method must assing button value to the class's editButton variable, otherwise setEditable() method creates multiple buttons
@ashklianko ashklianko added the Bug Something isn't working label May 6, 2024
@ashklianko ashklianko self-assigned this May 6, 2024
ashklianko added a commit that referenced this issue May 6, 2024
@ashklianko
BaseSelectedOptionView: typo in Edit button creation method #3555
b7e1485
@ashklianko ashklianko linked a pull request May 6, 2024 that will close this issue
BaseSelectedOptionView: typo in Edit button creation method #3555 #3556
Merged
alansemenov pushed a commit that referenced this issue May 7, 2024
@ashklianko @alansemenov
BaseSelectedOptionView: typo in Edit button creation method #3555
13eb141
@alansemenov alansemenov added Not in Changelog Quick fixes Refactoring Code improvements and removed Bug Something isn't working Not in Changelog Quick fixes labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Refactoring Code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BaseSelectedOptionView: typo in Edit button creation method #3555 enonic/lib-admin-ui
2 participants
@ashklianko @alansemenov