Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-selectable options in dropdowns should not be interactable #3521

Closed
alansemenov opened this issue Apr 3, 2024 · 0 comments · Fixed by #3527
Closed

Non-selectable options in dropdowns should not be interactable #3521

alansemenov opened this issue Apr 3, 2024 · 0 comments · Fixed by #3527
Assignees
@ashklianko @alansemenov
Labels
Bug Something isn't working

Comments

@alansemenov
Copy link
Member

alansemenov commented Apr 3, 2024 •
edited
Loading

Checkboxes on non-selectable options inside dropdowns should be styled as disabled. Now they look exactly like selectable ones - they can be clicked and unselected, but this will not affect selection when Apply is pressed. To avoid confusion they should not be interactable.

Expected look (the top 3 ones and the bottom one are non-selectable):
image
@alansemenov alansemenov added the Bug Something isn't working label Apr 3, 2024
@alansemenov alansemenov self-assigned this Apr 4, 2024
alansemenov added a commit that referenced this issue Apr 4, 2024
@alansemenov
Non-selectable options in dropdowns should not be interactable #3521
a2ddef0
@alansemenov alansemenov linked a pull request Apr 4, 2024 that will close this issue
Non-selectable options in dropdowns should not be interactable #3522
Closed
@ashklianko ashklianko self-assigned this Apr 5, 2024
ashklianko added a commit that referenced this issue Apr 5, 2024
@ashklianko
Non-selectable options in dropdowns should not be interactable #3521
a15deb3 
-Making rows be marked as 'readonly' rather than cells
@ashklianko ashklianko linked a pull request Apr 5, 2024 that will close this issue
Non-selectable options in dropdowns should not be interactable #3521 #3525
Closed
ashklianko added a commit that referenced this issue Apr 8, 2024
@ashklianko
Non-selectable options in dropdowns should not be interactable #3521
918f34f 
-Making rows be marked as 'readonly' rather than cells
@ashklianko ashklianko linked a pull request Apr 8, 2024 that will close this issue
Non-selectable options in dropdowns should not be interactable #3527
Merged
ashklianko added a commit that referenced this issue Apr 8, 2024
@ashklianko
Non-selectable options in dropdowns should not be interactable #3521
4224f4a 
-Making rows be marked as 'readonly' rather than cells
alansemenov pushed a commit that referenced this issue Apr 8, 2024
@ashklianko @alansemenov
Non-selectable options in dropdowns should not be interactable #3521
867dcb2
alansemenov pushed a commit that referenced this issue Apr 8, 2024
@ashklianko @alansemenov
Non-selectable options in dropdowns should not be interactable #3521
14f72af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

@alansemenov alansemenov

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@ashklianko @alansemenov