Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project create command should not start linked sandbox #536

Closed
sigdestad opened this issue Apr 16, 2024 · 5 comments · Fixed by #538
Closed

project create command should not start linked sandbox #536

sigdestad opened this issue Apr 16, 2024 · 5 comments · Fixed by #538
Assignees
Labels
Bug Something isn't working

Comments

@sigdestad
Copy link
Member

Running the following command: enonic create my.first.r4xp -r starter-react4xp -s r4xptutorial -f will automatically start the linked sandbox, but it should not.

FYI:
Commands like enonic (project) create -r starter-react4xp -f works fine, as these say you have to specify sandbox
Running enonic (project) create also works fine, as it will ask for every step (including creating and starting sandbox)

@alansemenov alansemenov added the Bug Something isn't working label Apr 16, 2024
@pmi
Copy link
Member

pmi commented Apr 24, 2024

@sigdestad Why not ? There is a reason it behaves this way:

Flag -f means default answer to all questions.
And there is a question at the end of creation of a project whether you want to run it with the default answer Y.
So it will break these rules if we make it behave differently here.

It tries to start it without the sandbox provided as well, but complains about it missing in the last line:

enonic create my.first.r4xp -r starter-react4xp -f
...
Sandbox distro and name must be set!

@alansemenov
Copy link
Member

The question is not in how "-f" flag works. It's about that CLI should suggest to start a sandbox only if sandbox was created as a part of the command execution. If a project is linked to an existing sandbox (as with -s r4xptutorial from the example above), it should not suggest to start it because no sandbox was created.

@pmi
Copy link
Member

pmi commented Apr 24, 2024

Hmm, I thought the reason it asked was you just created a project and wanted to deploy it ?
Not because you had to create a sandbox on the way 😕

@pmi
Copy link
Member

pmi commented Apr 24, 2024

Ok, I think I got it -- we only want to ask about starting sandbox after creating sandbox and nothing else ?

@alansemenov
Copy link
Member

Ok, I think I got it -- we only want to ask about starting sandbox after creating sandbox and nothing else ?

Correct

@pmi pmi linked a pull request Apr 26, 2024 that will close this issue
@alansemenov alansemenov changed the title project create / create should not start linked sandbox project create command should not start linked sandbox May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants