From 28b28a7f4f7896317094b65200d8bc5bf8f4bad2 Mon Sep 17 00:00:00 2001 From: John Hsu Date: Fri, 27 Oct 2017 03:24:53 -0500 Subject: [PATCH 1/4] Make sure present alert work properly (#95) --- code/Classes/Core/Arek.swift | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/code/Classes/Core/Arek.swift b/code/Classes/Core/Arek.swift index 43668dc..e5b0856 100644 --- a/code/Classes/Core/Arek.swift +++ b/code/Classes/Core/Arek.swift @@ -127,8 +127,10 @@ open class ArekBasePermission { while let presentedViewController = topController.presentedViewController { topController = presentedViewController } - - topController.present(alertVC, animated: true, completion: nil) + + DispatchQueue.main.async { + topController.present(alertVC, animated: true, completion: nil) + } } } @@ -152,8 +154,10 @@ open class ArekBasePermission { while let presentedViewController = topController.presentedViewController { topController = presentedViewController } - - topController.present(alert, animated: true, completion: nil) + + DispatchQueue.main.async { + topController.present(alert, animated: true, completion: nil) + } } } From eb2f9849137976db606934ab7602eac570f24e0e Mon Sep 17 00:00:00 2001 From: Woon Kung Lik Date: Tue, 5 Dec 2017 17:39:57 +0800 Subject: [PATCH 2/4] Update ArekNotifications.swift (#97) add sound permission. --- code/Classes/Permissions/ArekNotifications.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/Classes/Permissions/ArekNotifications.swift b/code/Classes/Permissions/ArekNotifications.swift index 6a4cba5..4a12333 100644 --- a/code/Classes/Permissions/ArekNotifications.swift +++ b/code/Classes/Permissions/ArekNotifications.swift @@ -64,7 +64,7 @@ open class ArekNotifications: ArekBasePermission, ArekPermissionProtocol { open func askForPermission(completion: @escaping ArekPermissionResponse) { if #available(iOS 10.0, *) { - UNUserNotificationCenter.current().requestAuthorization(options: [.alert, .badge]) { (granted, error) in + UNUserNotificationCenter.current().requestAuthorization(options: [.alert, .badge, .sound]) { (granted, error) in if let error = error { print("[🚨 Arek 🚨] Push notifications permission not determined 🤔, error: \(error)") return completion(.notDetermined) From 9d72fffcbbf3c5fcc5016cdf2f0fa67ec65bab55 Mon Sep 17 00:00:00 2001 From: Ennio Masi Date: Wed, 13 Dec 2017 13:25:15 +0000 Subject: [PATCH 3/4] PMAlertController dependecy updated (#98) * Updated PMAlertController to 3.1.0 * Fixed a typo into info.plist --- Cartfile | 2 +- Example/Podfile.lock | 38 ++++++++++++++++----------------- Example/arek_example/Info.plist | 2 ++ arek.podspec | 2 +- 4 files changed, 23 insertions(+), 21 deletions(-) diff --git a/Cartfile b/Cartfile index cf46a73..7060ec8 100644 --- a/Cartfile +++ b/Cartfile @@ -1 +1 @@ -github "Codeido/PMAlertController" +github "Codeido/PMAlertController", "3.1.0" diff --git a/Example/Podfile.lock b/Example/Podfile.lock index 5ee24a1..15bd5d7 100644 --- a/Example/Podfile.lock +++ b/Example/Podfile.lock @@ -15,52 +15,52 @@ PODS: - arek/Photos (= 1.6.0) - arek/Reminders (= 1.6.0) - arek/SpeechRecognizer (= 1.6.0) - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Bluetooth (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Camera (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/CloudKit (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Contacts (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Core (1.6.0): - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Events (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Health (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Location (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/MediaLibrary (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Microphone (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Motion (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Notifications (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Photos (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/Reminders (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) + - PMAlertController (= 3.1.0) - arek/SpeechRecognizer (1.6.0): - arek/Core - - PMAlertController (= 2.1.2) - - PMAlertController (2.1.2) + - PMAlertController (= 3.1.0) + - PMAlertController (3.1.0) DEPENDENCIES: - arek (from `../`) @@ -70,8 +70,8 @@ EXTERNAL SOURCES: :path: ../ SPEC CHECKSUMS: - arek: 24c5e1ece5f7c9c93a08f10243e717c78b26548c - PMAlertController: 0fbcc3d1cee86ee0bd85f693ca85f6388e504ec8 + arek: 39582884ee895f10a7e9cefb7421645fb8bb7bd5 + PMAlertController: 2c9f27b318e5adf685ba10737ff84be0a3ac5618 PODFILE CHECKSUM: 51391b981566b427912c687e0f5ba15813bf3aa4 diff --git a/Example/arek_example/Info.plist b/Example/arek_example/Info.plist index 24450a0..c5b784d 100644 --- a/Example/arek_example/Info.plist +++ b/Example/arek_example/Info.plist @@ -28,6 +28,8 @@ Let me read your contacts! NSLocationAlwaysUsageDescription Get me the Location Dude! + NSPhotoLibraryAddUsageDescription + Want to write to your photos! NSPhotoLibraryUsageDescription Want to access your photos! NSRemindersUsageDescription diff --git a/arek.podspec b/arek.podspec index bbca2fa..836a1ef 100644 --- a/arek.podspec +++ b/arek.podspec @@ -10,7 +10,7 @@ Pod::Spec.new do |s| s.ios.deployment_target = '9.0' s.source_files = 'code/Classes/**/*', 'code/Classes/Core/**/*', 'code/Classes/Permissions/**/*' s.exclude_files = 'Example/*' - s.dependency 'PMAlertController', '2.1.2' + s.dependency 'PMAlertController', '3.1.0' s.subspec 'Core' do |ss| ss.source_files = 'code/Classes/Core/**/*.swift' From 1cbd13b13cc2ded5b46c675cdca635daf419ccdd Mon Sep 17 00:00:00 2001 From: Ennio Masi Date: Wed, 13 Dec 2017 13:27:42 +0000 Subject: [PATCH 4/4] Version bump to 1.7.0 (#99) --- Example/Podfile.lock | 66 ++++++++++++++++++++++---------------------- arek.podspec | 2 +- 2 files changed, 34 insertions(+), 34 deletions(-) diff --git a/Example/Podfile.lock b/Example/Podfile.lock index 15bd5d7..afc02d1 100644 --- a/Example/Podfile.lock +++ b/Example/Podfile.lock @@ -1,63 +1,63 @@ PODS: - - arek (1.6.0): - - arek/Bluetooth (= 1.6.0) - - arek/Camera (= 1.6.0) - - arek/CloudKit (= 1.6.0) - - arek/Contacts (= 1.6.0) - - arek/Core (= 1.6.0) - - arek/Events (= 1.6.0) - - arek/Health (= 1.6.0) - - arek/Location (= 1.6.0) - - arek/MediaLibrary (= 1.6.0) - - arek/Microphone (= 1.6.0) - - arek/Motion (= 1.6.0) - - arek/Notifications (= 1.6.0) - - arek/Photos (= 1.6.0) - - arek/Reminders (= 1.6.0) - - arek/SpeechRecognizer (= 1.6.0) - - PMAlertController (= 3.1.0) - - arek/Bluetooth (1.6.0): + - arek (1.7.0): + - arek/Bluetooth (= 1.7.0) + - arek/Camera (= 1.7.0) + - arek/CloudKit (= 1.7.0) + - arek/Contacts (= 1.7.0) + - arek/Core (= 1.7.0) + - arek/Events (= 1.7.0) + - arek/Health (= 1.7.0) + - arek/Location (= 1.7.0) + - arek/MediaLibrary (= 1.7.0) + - arek/Microphone (= 1.7.0) + - arek/Motion (= 1.7.0) + - arek/Notifications (= 1.7.0) + - arek/Photos (= 1.7.0) + - arek/Reminders (= 1.7.0) + - arek/SpeechRecognizer (= 1.7.0) + - PMAlertController (= 3.1.0) + - arek/Bluetooth (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Camera (1.6.0): + - arek/Camera (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/CloudKit (1.6.0): + - arek/CloudKit (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Contacts (1.6.0): + - arek/Contacts (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Core (1.6.0): + - arek/Core (1.7.0): - PMAlertController (= 3.1.0) - - arek/Events (1.6.0): + - arek/Events (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Health (1.6.0): + - arek/Health (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Location (1.6.0): + - arek/Location (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/MediaLibrary (1.6.0): + - arek/MediaLibrary (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Microphone (1.6.0): + - arek/Microphone (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Motion (1.6.0): + - arek/Motion (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Notifications (1.6.0): + - arek/Notifications (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Photos (1.6.0): + - arek/Photos (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/Reminders (1.6.0): + - arek/Reminders (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - - arek/SpeechRecognizer (1.6.0): + - arek/SpeechRecognizer (1.7.0): - arek/Core - PMAlertController (= 3.1.0) - PMAlertController (3.1.0) @@ -70,7 +70,7 @@ EXTERNAL SOURCES: :path: ../ SPEC CHECKSUMS: - arek: 39582884ee895f10a7e9cefb7421645fb8bb7bd5 + arek: 234fa1d86f1950b9531f3d22aba75a1c7685add6 PMAlertController: 2c9f27b318e5adf685ba10737ff84be0a3ac5618 PODFILE CHECKSUM: 51391b981566b427912c687e0f5ba15813bf3aa4 diff --git a/arek.podspec b/arek.podspec index 836a1ef..b847b7a 100644 --- a/arek.podspec +++ b/arek.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'arek' - s.version = '1.6.0' + s.version = '1.7.0' s.summary = 'AREK is a clean and easy to use wrapper over any kind of iOS permission.' s.homepage = 'https://github.com/ennioma/arek' s.license = { :type => 'MIT', :file => 'LICENSE'}