Packaging and tests #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cag
commented
Nov 14, 2018
| return false; | ||
| constructor() internal { | ||
| _registerInterface( | ||
| // this.supportsInterface.selector ^ // <- include this? |
There was a problem hiding this comment.
I don't think ERC165 specified what to do in case interfaces have an inheritance structure.
Closed
|
Stale. See #6 for rebased stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning Truffle version to be used for development. Everything else removed as I did not see any point in their presence.
Also actually rely on Zeppelin instead of having copied files in the contracts.
I had to change test files from ES6 to CJS modules to get it to work with the test runner.
Also see ethereum/solidity#3419. There's a commit to use the abstract contract workaround for now.