Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of plurals #114

Open
INCIBE-CERT opened this issue Sep 2, 2021 · 4 comments · May be fixed by #116
Open

Use of plurals #114

INCIBE-CERT opened this issue Sep 2, 2021 · 4 comments · May be fixed by #116

Comments

@INCIBE-CERT
Copy link
Contributor

INCIBE-CERT commented Sep 2, 2021 •
edited
Loading

Some RSIT use Plural in the (sub)classification names:

  • Intrusion Attempts
  • Intrusions
  • Login Attempts
  • Potentially Unwanted Accessible Services

However, most of them are in singular:

  • Denial of Service
  • {Account,Application,System} Compromise
  • Unauthorised Modification of Information
  • Misconfiguration
  • Vulnerable
  • Burglary
  • Vulnerable System
  • Phishing
  • etc.

Use of singular seems better suited. If you suffer an incident it is an intrusion, not intrusions.

Expected action: rename the plural names to singular form
@sebix
Copy link
Contributor

sebix commented Sep 3, 2021

That also affects the machine-readable names (predicates), so that would be a major change.

@INCIBE-CERT
Copy link
Contributor Author

We expected to change only the display name, not the machine one.

@amicaross
Copy link
Contributor

agreed - new issue to be created

@amicaross amicaross reopened this Sep 9, 2021
INCIBE-CERT pushed a commit to INCIBE-CERT/Reference-Security-Incident-Taxonomy-Task-Force that referenced this issue Sep 9, 2021
Change plurals into sigular in the human names
b2a3eaa 
As agreed on 9/9/2021 meeting.

Fixes enisaeu#114
@INCIBE-CERT INCIBE-CERT linked a pull request Sep 9, 2021 that will close this issue
Open
INCIBE-CERT pushed a commit to INCIBE-CERT/Reference-Security-Incident-Taxonomy-Task-Force that referenced this issue Sep 9, 2021
Change plurals into singular in the human names
6629fab 
As agreed on 9/9/2021 meeting.

Fixes enisaeu#114
INCIBE-CERT pushed a commit to INCIBE-CERT/Reference-Security-Incident-Taxonomy-Task-Force that referenced this issue Sep 9, 2021
Change plurals into singular in the human names
fed05df 
As agreed on 9/9/2021 meeting.

Fixes enisaeu#114
INCIBE-CERT pushed a commit to INCIBE-CERT/Reference-Security-Incident-Taxonomy-Task-Force that referenced this issue Sep 9, 2021
Change plurals into singular in the human names
7bc4ad5 
As agreed on 9/9/2021 meeting.

Fixes enisaeu#114
@sebix sebix mentioned this issue Sep 18, 2021
Closed
2 tasks
@sebix
Copy link
Contributor

sebix commented Sep 18, 2021

agreed - new issue to be created

Not exactly. We agreed that we change the non-breaking wordings until the next meeting (to be concluded then) but not do the renames right now. We rather collect multiple breaking changes for the next major version. And to not forget about that, we create a separate issue -> #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sebix @amicaross @INCIBE-CERT