Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbundle fonts #341

Closed
alecpl opened this issue Aug 4, 2021 · 4 comments
Closed

Unbundle fonts #341

alecpl opened this issue Aug 4, 2021 · 4 comments
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@alecpl
Copy link

alecpl commented Aug 4, 2021

Distributing the package with a project release increases the size by ~15MB, which is a lot.

Please, consider moving fonts into a separate, optional package. All fonts, or only the OTF.

@endroid endroid self-assigned this Aug 4, 2021
@endroid endroid added the duplicate This issue or pull request already exists label Aug 4, 2021
@endroid
Copy link
Owner

endroid commented Aug 4, 2021

Hi @alecpl thank you for your input. I will not remove the font but if you can provide a much smaller compatible font I will be happy to replace it. See #103 and #224.

@endroid endroid closed this as completed Aug 4, 2021
@alecpl
Copy link
Author

alecpl commented Aug 4, 2021

I fail to see where the OTF font is used/required in the code.

@endroid
Copy link
Owner

endroid commented Aug 4, 2021

Here you can see it is the default font https://www.github.com/endroid/qr-code/tree/master/src%2FLabel%2FLabel.php

@alecpl
Copy link
Author

alecpl commented Aug 28, 2021

For those not needing a text on QR-code a solution is to use bacon/bacon-qr-code directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants