From eb31fac82a5b304b82c4eb2bd4eda0f99091199e Mon Sep 17 00:00:00 2001 From: Mirko Galimberti Date: Tue, 29 Nov 2022 17:39:38 +0100 Subject: [PATCH] Flake8 does not support inline comments for any of the keys. (#2708) * Flake8 does not support inline comments for any of the keys. * Fix flake8 E741 ambiguous variable name (cherry picked from commit 8f8cf6a4c89d0f8a53b700c6b5d299d0080ca4ec) --- pythonforandroid/recipe.py | 2 +- tox.ini | 24 ++++++++++++++++-------- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/pythonforandroid/recipe.py b/pythonforandroid/recipe.py index b4cd9bb3cf..299a795477 100644 --- a/pythonforandroid/recipe.py +++ b/pythonforandroid/recipe.py @@ -629,7 +629,7 @@ def install_libs(self, arch, *libs): shprint(sh.cp, *args) def has_libs(self, arch, *libs): - return all(map(lambda l: self.ctx.has_lib(arch.arch, l), libs)) + return all(map(lambda lib: self.ctx.has_lib(arch.arch, lib), libs)) def get_libraries(self, arch_name, in_context=False): """Return the full path of the library depending on the architecture. diff --git a/tox.ini b/tox.ini index ceafe446b5..9b0432c82b 100644 --- a/tox.ini +++ b/tox.ini @@ -27,11 +27,19 @@ commands = flake8 pythonforandroid/ tests/ ci/ setup.py [flake8] ignore = - E123, # Closing bracket does not match indentation of opening bracket's line - E124, # Closing bracket does not match visual indentation - E126, # Continuation line over-indented for hanging indent - E226, # Missing whitespace around arithmetic operator - E402, # Module level import not at top of file - E501, # Line too long (82 > 79 characters) - W503, # Line break occurred before a binary operator - W504 # Line break occurred after a binary operator + # Closing bracket does not match indentation of opening bracket's line + E123, + # Closing bracket does not match visual indentation + E124, + # Continuation line over-indented for hanging indent + E126, + # Missing whitespace around arithmetic operator + E226, + # Module level import not at top of file + E402, + # Line too long (82 > 79 characters) + E501, + # Line break occurred before a binary operator + W503, + # Line break occurred after a binary operator + W504