Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu is no longer working anywhere #837

Open
dylanmccall opened this issue Sep 20, 2023 · 0 comments
Open

Context menu is no longer working anywhere #837

dylanmccall opened this issue Sep 20, 2023 · 0 comments

Comments

@dylanmccall
Copy link
Collaborator

dylanmccall commented Sep 20, 2023

In #829, we added a change in the ContentModal component which prevents the context menu from appearing. According to #828, we should only be disabling the context menu inside that modal, but the change disabled the context menu everywhere.

In the current implementation, we are adding a listener for the "contextmenu" event to window. Based on the information at MDN, this event bubbles up from an element which was right clicked. So, instead of attaching the listener to window, we should add it to the modal container itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant