Skip to content

Commit

Permalink
Revert "Raise TypeError on invalid query params. (#2523)" (#2539)
Browse files Browse the repository at this point in the history
This reverts commit 4cbf13e.
  • Loading branch information
zanieb authored Jan 4, 2023
1 parent e27d1b8 commit bddd774
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
6 changes: 1 addition & 5 deletions httpx/_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,7 @@ def primitive_value_to_str(value: "PrimitiveData") -> str:
return "false"
elif value is None:
return ""
elif isinstance(value, (str, float, int)):
return str(value)
raise TypeError(
f"Expected str, int, float, bool, or None. Got {type(value).__name__!r}."
)
return str(value)


def is_known_encoding(encoding: str) -> bool:
Expand Down
7 changes: 0 additions & 7 deletions tests/models/test_queryparams.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,6 @@ def test_empty_query_params():
assert str(q) == "a="


def test_invalid_query_params():
with pytest.raises(
TypeError, match=r"Expected str, int, float, bool, or None. Got 'bytes'."
):
httpx.QueryParams({"a": b"bytes"})


def test_queryparam_update_is_hard_deprecated():
q = httpx.QueryParams("a=123")
with pytest.raises(RuntimeError):
Expand Down

0 comments on commit bddd774

Please sign in to comment.