Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated IPAddressField validation errors with ModelSerializer #3250

Closed
callorico opened this issue Aug 8, 2015 · 2 comments
Closed

Duplicated IPAddressField validation errors with ModelSerializer #3250

callorico opened this issue Aug 8, 2015 · 2 comments
Labels
Milestone

Comments

@callorico
Copy link
Contributor

I'm seeing duplicated validation errors being returned from a ModelSerializer for a model containing a GenericIPAddressField on Django 1.8.3 and Python 2.7.9.

{'address': [u'Enter a valid IPv4 or IPv6 address.', u'Enter a valid IPv4 or IPv6 address.']}

It looks like both the validator from the GenericIPAddressField and the validator from the DRF IPAddressField are being called.

#3249

@callorico callorico changed the title Duplicated validation errors with ModelSerializer Duplicated IPAddressField validation errors with ModelSerializer Aug 8, 2015
@xordoquy
Copy link
Collaborator

xordoquy commented Aug 8, 2015

Thanks for the failing test case

@tomchristie tomchristie added this to the 3.2.3 Release milestone Aug 20, 2015
@tomchristie
Copy link
Member

Now resolved in master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants