django version requirements

[dmitry-mukhin]

Django>=1.4.2 does not cut it, as older minor versions have older version of six.

[tomchristie]

Now resolved. Believe already correct in the docs, but do shout out if I've missed somewhere.

[dmitry-mukhin]

well, >=1.5,<1.5.6 will still fail.

[tomchristie]

Is that actually resolvable in requirements.txt? Is it possible to specify the requirements like that?
We do list the requirements correctly in the docs, right? And pip install -r requirements.txt will be correct.

[dmitry-mukhin]

it's possible.
the problem that I have faced and want others to avoid is that upgrading drf to 3.0 may stop project working without any warnings, and one have to investigate and find that there is a conflict with installed django.

providing proper requirements would alert and point out the problem during setup.

[xordoquy]

I'm a bit curious. Why do we need a requirements.txt ?

[jpadilla]

@xordoquy my guess is something regarding contributing/testing. If that's why, perhaps we should just include Django in the requirements-test.txt.

[tomchristie]

Just there by convention really I guess. We could get rid of it maybe?

[xordoquy]

My feeling is we should get rid of it. Ought we to have some, i'd rather have it in the setup's install_requires section.

[jpadilla]

I think we can just move it to requirements-test.txt just so we don't "disrupt" the testing/contributing setup.

I'm usually against adding a dependency into install_requires for this case, which by default might upgrade Django's version to someone while upgrading DRF. pip has a a way to avoid this from happening using something like pip install --upgrade --no-deps djangorestframework but then we'd have to document that.

[xordoquy]

@jpadilla good point.

[tomchristie]

We don't need the requirement in setup, happy for that to be implicit.
And yeah sure, move the django requirement to just be in the requirements-test.txt (Alternatively we could possibly even just call that requirements.txt and have a comment on the first line)

[jpadilla]

Yeah that sounds good, will open a PR with that.