Test models should exist in corresponding test case, not in a global models.py.

[xordoquy]

Due to a side effect with Django 1.7, some test models have been moved within the models file of the test application.
Following what has been said in #1398 this may not be what we want.

I'm fine with models being defined in the test application models file. This is open to discussion.

[tomchristie]

"test application models file"

Sorry, I didn't fully understand this. Specifically which test files are we talking about here?
Yes to models being within the test module itself, rather than a seperate models.py module, if possible.

[xordoquy]

By "test application models file" I meant in the models.py that is contained in the test project/app (tests/models.py)
If you really want them separated we will have some renaming to do to preserve unique name.

[tomchristie]

Happy to approach it incrementally.
Related to this is the oddities of having a tests/serializers.py and other similar modules.

[xordoquy]

This one will be easier to deal with

[tomchristie]

"This one"

You mean the serializers.py module, or something else?

[tomchristie]

This doesn't particularly need to block a 2.4 release - removing the milestone.

[maryokhin]

I was a bit curious and took a peek at tests/models.py and kind of broke a leg. In the sense that I'm either not understanding something, or that module is seriously outdated. I found about 10 models that are not used at all, and some models that are used only in *.md files.

For example BlogPost model is only referenced in UniqueValidator section in validators.md, but nowhere in the code. And there's a couple of them like that. Was that the purpose of defining it in models.py or is it a coincidence in naming?

[tomchristie]

Note it's almost certainly just because there's a bunch of stuff in there that's no longer used.

(Kinda the motivation of this issue to prevent this sort of thing)

Delete those models at will! :)

[maryokhin]

Opened #2161 to start cleaning them up.

[tomchristie]

V nice!

[tomchristie]

The relational models in there probably need to stay - tried moving them into seperate test case modules, but the reverse relationships raised conflicts due to duplicated names or something.
Still a few BasicModel cases that can be removed tho, and then we should comment at the top of the module pointing folks towards implementing in the test case module as a preference.

[xordoquy]

Was #2161 enough to close this issue or do we still have some related work ?

[tomchristie]

Mostly resolved. Remaining stuff isn't worth keeping on our todo list anymore.
Perhaps if we reach a static point with very little ongoing feature work then we could consider further test cleanups.