Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace Ring with RustCrypto in pki.rs #61

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

rjzak
Copy link
Member

@rjzak rjzak commented Sep 28, 2022

Added "BSD-3-Clause" license to deny.toml since it's used by a RustCrypto dependency.

Signed-off-by: Richard Zak [email protected]

@rjzak rjzak requested review from a team, bstrie and haraldh as code owners September 28, 2022 18:09
@rjzak rjzak changed the title chore: Replace Ring with RustCrypto in pki.rs chore: replace Ring with RustCrypto in pki.rs Sep 28, 2022
Cargo.toml Outdated Show resolved Hide resolved
src/crypto/pki.rs Outdated Show resolved Hide resolved
@rjzak rjzak requested a review from npmccallum September 28, 2022 18:21
@rjzak
Copy link
Member Author

rjzak commented Sep 28, 2022

The only failure is Cargo/deny being upset about the RustCrypto project using a crate called subtle which is BSD-licensed, and that's approved?

@npmccallum
Copy link
Member

The only failure is Cargo/deny being upset about the RustCrypto project using a crate called subtle which is BSD-licensed, and that's approved?

Yes. Add it to deny.toml. In the future, do that presumptively and point out the additional license in the PR text so that reviewers can assess whether that change is acceptable or not.

@rjzak rjzak force-pushed the removing_ring_pki branch 2 times, most recently from e087ad9 to 34e2b60 Compare September 28, 2022 20:39
@npmccallum npmccallum enabled auto-merge (rebase) September 28, 2022 20:46
@npmccallum npmccallum merged commit 7e84a2d into enarx:main Sep 28, 2022
@rjzak rjzak deleted the removing_ring_pki branch September 28, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants