Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple list-like settings should get merged instead of overriding each other #19058

Open
RReverser opened this issue Mar 24, 2023 · 1 comment · May be fixed by #19938
Open

Multiple list-like settings should get merged instead of overriding each other #19058

RReverser opened this issue Mar 24, 2023 · 1 comment · May be fixed by #19938

Comments

@RReverser
Copy link
Collaborator

While working on .NET stuff, we noticed that currently having multiple -sEXPORTED_FUNCTIONS means that whichever is last, wins, which is not great when you want to pass an export file generated by tooling + statically some extra functions that need to be always exported. For example, if you specify:

-s [email protected] -s EXPORTED_FUNCTIONS=_OneMoreExport

Then today only OneMoreExport will end up exported and file ignored; if you change the order, the opposite happens.

It would be more useful for them to get merged instead. While chatting to @sbc100 about this idea, he suggested that the same should probably apply to other list-like settings too, e.g. ASYNCIFY_IMPORTS.

@sbc100
Copy link
Collaborator

sbc100 commented Mar 24, 2023

I think we have considered this in the past (things might even have worked this way in the past). I can't think of any reason not to do this .. I would imagine we should do it consistently for all list-taking arguments.

@sbc100 sbc100 linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants