Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Template comments are not removed on prod build #1676

Open
1 task done
davidglezz opened this issue Dec 10, 2024 · 0 comments
Open
1 task done

[BUG]: Template comments are not removed on prod build #1676

davidglezz opened this issue Dec 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@davidglezz
Copy link
Contributor

davidglezz commented Dec 10, 2024

Environment affected

No response

Description

image

image

Current behavior and expected result

Comments are not stripped.

Impact:

  • Performance: Bundle size, useless comment rendering..
  • IMPORTANT: Breaks attribute inheritance!
    • Templates with comments at root level will make the component having multiple children (comment + element)

Steps to reproduce

No response

Package affected

No response

Supporting information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@davidglezz davidglezz added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant