Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnessary try statement when importing rdflib.Graph #317

Closed
wants to merge 3 commits into from
Closed

Removed unnessary try statement when importing rdflib.Graph #317

wants to merge 3 commits into from

Conversation

jesper-friis
Copy link
Collaborator

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@jesper-friis jesper-friis requested a review from CasperWA December 2, 2021 15:58
CasperWA
CasperWA reviewed Dec 2, 2021
View reviewed changes
tools/ontoconvert
Comment on lines +8 to +9
from rdflib.graph import Graph
from rdflib.util import guess_format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of my fix in #307

@CasperWA CasperWA added the duplicate This issue or pull request already exists label Dec 2, 2021
@CasperWA
Copy link
Contributor

CasperWA commented Dec 2, 2021

Closing, as this is a duplicate of #307

@CasperWA CasperWA closed this Dec 2, 2021
@CasperWA CasperWA deleted the simplify-ontoconvert-import branch December 2, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA left review comments

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesper-friis @CasperWA