-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check first versionIRI then versionInfo in ontology.get_version() #301
Conversation
@jesper-friis the tools/ontoversion is not implemented correctly yet as I want us to decide if this is the right approach first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good.
My only question is whether we should encourage setting versionInfo to just be the version number without the prepended "v".
Sure, it did it to keep track of versionIRI vs versionInfo, but it should be removed now. |
Description:
Improve on get_version in ontology so that also versionInfo is checked for.
See discussion on #299
Also changed so that rdflib can guess format in ontoversion.
Ontoversion only checks for version from versionIRI as this should be the case for a correctly defined ontology.
Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: