Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest pylint (2.15.4) has intriduced some new rules. #534

Closed
francescalb opened this issue Feb 2, 2023 · 2 comments · Fixed by #535
Closed

Newest pylint (2.15.4) has intriduced some new rules. #534

francescalb opened this issue Feb 2, 2023 · 2 comments · Fixed by #535
Assignees

Comments

@francescalb
Copy link
Collaborator

See error when running pre-commit run --all-files

@francescalb francescalb self-assigned this Feb 2, 2023
@CasperWA
Copy link
Contributor

CasperWA commented Feb 2, 2023

I think we should consider "pinning"/allowing a more restrictive range of pylint versions (as discussed offline). So instead of having the dependency be pylint~=2.15, which is equal to pylint>=2.15,<3, it should probably only allow a specific minor version at a time, i.e.: pylint~=2.15.0 or similar, which is equal to pylint>=2.15.0,<2.16.

An alternative is to use == and stick to a single specific version at any given time. While this, honestly, might be the best solution for this package, it also gives rise to certain issues/annoyances:

  • Many more pylint package dependabot PRs.
  • A possibility to lose out on automatically published hotfixes.

@francescalb
Copy link
Collaborator Author

Hmm... I don't think that we have run into a situation where it is impossible to keep up with pylint restrictions yet. I'd rather keep it as is and try to stay on top of new released suggestions for improved code (but one can also decide on a team-level to disregard certain rules, altough I prefer to keep this to an absolute minimum).

@francescalb francescalb linked a pull request Feb 4, 2023 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants