-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check out how to get version of ontology #299
Comments
There is already a sufficient error message in ontology.get_version(), which is: Inferring from other tags I think is a bad idea as this will open up for mistakes that are difficult to track later. The default version in ontoversion should be ttl, and it would be nice to have a better error message here, that suggests including format. |
Determine whether |
I want to add the possibility of getting the version from the versionInfo as well as from the versionIRI. Which one do you think should have precedence? |
Since the semantics of owl:versionInfo is not well defined on https://www.w3.org/TR/owl-ref/#versionInfo-def, I think versionIRI should have precedence. However, on https://www.w3.org/TR/2004/REC-owl-guide-20040210/#OntologyVersioning they indicate that |
OK, from the above discussion I propose to do as follows: if as_iri:
return VersionIRI of versionIRI else Exception versionIRImissing
else:
if version_iri:
return version inferred from version_iri and base_iri
elif versionInfo:
return versionINFO
else:
raise NoVersionInfoFound.... I guess, then the only reason make this change is to find version from versionInfo if the ontology is malformed and does not have versionIRI (which it should have). Comments? |
@jesper-friis , you were quick on approving the draft, can you please comment on this? |
Currently get_ontology of emmo-inferred (latest-stable) fails as versionIRI is missing.
Look into how to make better error message and perhaps infer from other tags if versionIRI is missing.
Also ontoversion fails and must be checked.
The text was updated successfully, but these errors were encountered: