Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting get_triples() method #280

Closed
CasperWA opened this issue Nov 2, 2021 · 4 comments · Fixed by #281
Closed

Overwriting get_triples() method #280

CasperWA opened this issue Nov 2, 2021 · 4 comments · Fixed by #281
Assignees
Labels
bug Something isn't working

Comments

@CasperWA
Copy link
Contributor

CasperWA commented Nov 2, 2021

This method was erroneously overwritten in #246 for ontopy.ontology.Ontology. The method name should be changed.

@CasperWA CasperWA added the bug Something isn't working label Nov 2, 2021
@CasperWA CasperWA self-assigned this Nov 2, 2021
@CasperWA
Copy link
Contributor Author

CasperWA commented Nov 2, 2021

As a note, @francescalb, should the unabbreviate function go through self.world.get_triples() or self.get_triples()? Or is this the same?

@francescalb
Copy link
Collaborator

It is actually the same. Both World and Ontology inherit from _Graphmanager in owlready2, and get_triples is defined as a function of _Graphmanager.

@CasperWA
Copy link
Contributor Author

CasperWA commented Nov 2, 2021

Great - that's what I could reason myself to as well, I just wanted to make sure - do you mind if I change from self.world.get_triples() to self.get_triples() then? Since only the latter is used elsewhere in the file already.

@francescalb
Copy link
Collaborator

No, that is smart. This explains my initial mistake as well. I found get_triples() in world and did not check well enough if it was defined in ontology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants