Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package specific base exception and base warning for EMMOntoPy #322

Merged
merged 4 commits into from
Dec 10, 2021

Conversation

francescalb
Copy link
Collaborator

Description:

Package specific base exception and warning are good practice.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb francescalb requested a review from CasperWA December 7, 2021 08:58
@francescalb francescalb linked an issue Dec 7, 2021 that may be closed by this pull request
ontopy/utils.py Outdated Show resolved Hide resolved
@francescalb francescalb requested a review from CasperWA December 10, 2021 09:38
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @francescalb

@CasperWA CasperWA enabled auto-merge (squash) December 10, 2021 09:49
@CasperWA CasperWA merged commit c76e9a7 into master Dec 10, 2021
@CasperWA CasperWA deleted the flb/close-321-baseexception branch December 10, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make EMMOntoPy baseexception and basewarning
2 participants