Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any chance of a build supporting netstandard2.0? #11

Closed
jskeet opened this issue Jan 31, 2018 · 3 comments · May be fixed by #12
Closed

Any chance of a build supporting netstandard2.0? #11

jskeet opened this issue Jan 31, 2018 · 3 comments · May be fixed by #12

Comments

@jskeet
Copy link

jskeet commented Jan 31, 2018

I suspect the current code will work with .NET Core apps, but it would be nice to be more specific about it by explicitly targeting netstandard2.0.

I realize this project may be seen as "mostly legacy" now, so completely understand if the request is rejected :)
@emmettnicholas
Copy link
Owner

Thanks-- I'm a bit removed from the .NET game at the moment, so would have trouble easily verifying whether it works with .NET Core. You're right that this "mostly legacy" at this point, but is the suggestion to just update the README, or is there something else I'd need to do as well?

@jskeet
Copy link
Author

jskeet commented Jan 31, 2018

It would involve updating the build process and creating a new release. If you're not doing much .NET work at the moment, it's probably not worth it :)

I'm just updating my web sites to use ASP.NET Core at the moment - if I can't get StacMan to work, I'll just look at alternatives... thanks!

@petrsvihlik
Copy link
Contributor

petrsvihlik commented Jun 20, 2018 •
edited
Loading

@emmettnicholas Have you considered involving more people in this project? I personally would be interested in reviving and maintaining this project. With just a little care it could be up to the current .NET standards again.

@jskeet We use StacMan internally in our company and I too would appreciate if it targeted netstandard2.0. (Btw - did you go with an alternative solution in the end?)

0xced added a commit to 0xced/StacMan that referenced this issue Apr 21, 2021
@0xced
Modernize project and target .NET Standard 2.0
b95353e 
* Upgrade projects to the new "SDK style" csproj format
  * Remove the packages directory and packages.config file
  * Remove `AssemblyInfo.cs` files (replaced with equivalent csproj properties)
  * Remove `*.vsmdi` and `*.testsettings` files
  * Run tests on .NET Framework 4.7.2 + .NET Core 3.1 + .NET 5.0
  * Update test dependencies to their latest version 
    * Microsoft.NET.Test.Sdk → 16.9.4
    * Moq → 4.16.1
    * MSTest.TestAdapter → 2.2.3
    * MSTest.TestFramework → 2.2.3

* Use `System.Text.Json` instead of `System.Web.Script.Serialization`
  * Use `JsonPropertyNameAttribute` instead of `FieldAttribute`
  * Make properties `{ get; init; }` instead of `{ get; internal set; }` with the help of the `IsExternalInit` NuGet package to support .NET Standard 2.0
  * Define `EnumMember` attributes for all enums and use `JsonStringEnumMemberConverter` from the `Macross.Json.Extensions` NuGet package to workaround [issues in JsonStringEnumConverter](dotnet/runtime#31619)

Fixes emmettnicholas#11
@0xced 0xced mentioned this issue Apr 21, 2021
Open
0xced added a commit to 0xced/StacMan that referenced this issue Apr 22, 2021
@0xced
Modernize project and target .NET Standard 2.0
9c9a29e 
* Upgrade projects to the new "SDK style" csproj format
  * Remove the packages directory and packages.config file
  * Remove `AssemblyInfo.cs` files (replaced with equivalent csproj properties)
  * Remove `*.vsmdi` and `*.testsettings` files
  * Run tests on .NET Framework 4.7.2 + .NET Core 3.1 + .NET 5.0
  * Update test dependencies to their latest version 
    * Microsoft.NET.Test.Sdk → 16.9.4
    * Moq → 4.16.1
    * MSTest.TestAdapter → 2.2.3
    * MSTest.TestFramework → 2.2.3

* Use `System.Text.Json` instead of `System.Web.Script.Serialization`
  * Use `JsonPropertyNameAttribute` instead of `FieldAttribute`
  * Make properties `{ get; init; }` instead of `{ get; internal set; }` with the help of the `IsExternalInit` NuGet package to support .NET Standard 2.0
  * Define `JsonPropertyName` attributes for all enums and use `JsonStringEnumMemberConverter` from the `Macross.Json.Extensions` NuGet package to workaround [issues in JsonStringEnumConverter](dotnet/runtime#31619)

Fixes emmettnicholas#11
0xced added a commit to 0xced/StacMan that referenced this issue Feb 18, 2022
@0xced
Modernize project and target .NET Standard 2.0
0c90f16 
* Upgrade projects to the new "SDK style" csproj format
  * Remove the packages directory and packages.config file
  * Remove `AssemblyInfo.cs` files (replaced with equivalent csproj properties)
  * Remove `*.vsmdi` and `*.testsettings` files
  * Run tests on .NET Framework 4.7.2 + .NET Core 3.1 + .NET 6.0
  * Update test dependencies to their latest version 
    * Microsoft.NET.Test.Sdk → 17.1.0
    * Moq → 4.16.1
    * MSTest.TestAdapter → 2.2.8
    * MSTest.TestFramework → 2.2.8

* Use `System.Text.Json` instead of `System.Web.Script.Serialization`
  * Use `JsonPropertyNameAttribute` instead of `FieldAttribute`
  * Make properties `{ get; init; }` instead of `{ get; internal set; }` with the help of the `IsExternalInit` NuGet package to support .NET Standard 2.0
  * Define `JsonPropertyName` attributes for all enums and use `JsonStringEnumMemberConverter` from the `Macross.Json.Extensions` NuGet package to workaround [issues in JsonStringEnumConverter](dotnet/runtime#31619)

Fixes emmettnicholas#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modernize project and target .NET Standard 2.0 0xced/StacMan
3 participants
@jskeet @emmettnicholas @petrsvihlik