Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate asynctest to stdlib's AsyncMock #3

Closed
fabaff opened this issue Feb 12, 2021 · 2 comments · Fixed by #4
Closed

Migrate asynctest to stdlib's AsyncMock #3

fabaff opened this issue Feb 12, 2021 · 2 comments · Fixed by #4

Comments

@fabaff
Copy link
Contributor

fabaff commented Feb 12, 2021

pyzerproc/requirements_dev.txt

Line 16 in 06a8994

asynctest==0.13.0

Asynctest doesn't work with Python 3.8 and above.

Asynctest upstream is aware of this breakage and recommends using the built-in AsyncMock instead.

See also Martiusweb/asynctest#144 and Martiusweb/asynctest#126
@emlove emlove mentioned this issue Feb 12, 2021
Merged
@emlove emlove closed this as completed in #4 Feb 12, 2021
@emlove
Copy link
Owner

emlove commented Feb 12, 2021

I've published version 0.4.8 that incorporates these dependency cleanups. Thanks for letting me know!

@fabaff
Copy link
Contributor Author

fabaff commented Feb 13, 2021

Thanks a lot for the quick "intervention".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use built-in AsyncMock on Python 3.8+ emlove/pyzerproc
2 participants
@fabaff @emlove