Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in to AuthService #5291

Open
eevdev opened this issue Sep 13, 2023 · 1 comment
Open

Opt-in to AuthService #5291

eevdev opened this issue Sep 13, 2023 · 1 comment
Labels
stale Issue is stale and will be closed t:feature New feature or enhancement request

Comments

@eevdev
Copy link
Contributor

eevdev commented Sep 13, 2023

Please describe your use case / problem.
I have a setup where an Emissary-ingress is shared with multiple services. To support auth for some of those services I could introduce an AuthService, but that would then enable it for all the ones that don't need it, unless adding bypass_auth: true to all other Mappings.

Enabling AuthService for some services shouldn't break or put to risk other services.

Describe the solution you'd like
Option to opt-in to the AuthService instead of opt-out.

Being able to set the default value for bypass_auth to true would work, so that those services that need auth have to opt-in by setting it to false. The Helm chart should also support this option.

Describe alternatives you've considered
Add bypass_auth: true to all other Mappings, including adding support for that to all relevant Helm charts etc.

Additional context
Related to #174

@cindymullins-dw cindymullins-dw added the t:feature New feature or enhancement request label Sep 14, 2023
@gecube
Copy link

gecube commented Oct 18, 2023

I had the same thoughts. Another option is to configure and / or rewrite auth-service itself creating an allow-list of FQDNs and endpoints which will be protected by authentication (or otherwise - skipped). The drawback is that all traffic will still go to auth-service and if it fails all services not requiring authentication will be unavailable.

@dosubot dosubot bot added the stale Issue is stale and will be closed label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue is stale and will be closed t:feature New feature or enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants