New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yet more tests for TCPMappings #4516

Open

LukeShu opened this issue Sep 16, 2022 · 0 comments

Labels

Contributor

LukeShu commented Sep 16, 2022 •

edited

Loading

From #4477, in t_tcpmapping.py (see also: #4493 (comment)):

# TODO: Add tests for all of the config knobs for the upstream connection:
#  - enable_ipv4: false
#  - enable_ipv6: false
#  - circuit_breakers
#  - idle_timeout_ms
#  - resolver
#
# TODO: Add tests for the config knobs for stats:
#  - cluster_tag
#  - stats_name (v3alpha1 only)

The text was updated successfully, but these errors were encountered:

LukeShu mentioned this issue

[v2.4] Add more tests for TCPMappings #4493

Merged

5 tasks

LukeShu added the a:tests label

dosubot bot added the stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment