Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Tracing config faulty in 2.3 #4267

Closed
psalaberria002 opened this issue Jun 8, 2022 · 2 comments
Closed

Regression: Tracing config faulty in 2.3 #4267

psalaberria002 opened this issue Jun 8, 2022 · 2 comments
Assignees

Comments

@psalaberria002
Copy link
Contributor

Describe the bug
When upgrading to 2.3 the pods are not coming up healthy.

[2022-06-08 16:13:44.556][49][critical][main] [source/server/server.cc:109] error initializing configuration '/ambassador/bootstrap-ads.json': Protobuf message (type envoy.config.bootstrap.v3.Bootstrap reason INVALID_ARGUMENT:trace_id_128bit: Cannot find field.) has unknown fields
Protobuf message (type envoy.config.bootstrap.v3.Bootstrap reason INVALID_ARGUMENT:trace_id_128bit: Cannot find field.) has unknown fields

That config is for Zipkin, and it should not have been there when using other drivers such as Lightstep.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy a TracingService where the driver is not zipkin (lightstep for example)
  2. Wait for pods to crash

Expected behavior
Envoy should start without issues.

Versions (please complete the following information):

  • Ambassador: 2.3.0

Additional context
a41b100 broke the logic, by adding zipkin related fields no matter which driver you choose.

@LukeShu
Copy link
Contributor

LukeShu commented Jun 8, 2022

... yup, I sure messed that up. @LanceEa tells me he's working on the fix.

@kai-tillman kai-tillman changed the title Tracing config faulty in 2.3 Regression: Tracing config faulty in 2.3 Jun 8, 2022
@LanceEa
Copy link
Contributor

LanceEa commented Jun 12, 2022

@psalaberria002 - 2.3.1 went out on Friday with a patch for this. I verified the unit test is passing and smoked tested. Can you give the new release a try and let me know if you are still seeing issues?

@LanceEa LanceEa closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants