Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapping.weight should not be modified by weight normalization #3945

Closed
kflynn opened this issue Nov 23, 2021 · 2 comments
Closed

Mapping.weight should not be modified by weight normalization #3945

kflynn opened this issue Nov 23, 2021 · 2 comments
Assignees
@kflynn
Labels
t:bug Something isn't working w:6 Targeted for sixth week of development cycle
Milestone
2021 Cycle 7

Comments

@kflynn
Copy link
Member

kflynn commented Nov 23, 2021

When normalizing the weights of the Mappings in a MappingGroup (so that every Mapping has a weight, and all the weights in the Group sum to 100), the code currently modifies Mapping.weight. This can cause mis-weighted Mappings when the Group is reconfigured with the cache active.

This should, instead, do calculations in a different attribute, so that the user's original assigned weight isn't altered in the cache.
@kflynn kflynn self-assigned this Nov 23, 2021
@khussey khussey added this to the 2021 Cycle 7 milestone Nov 24, 2021
@khussey khussey added t:bug Something isn't working w:6 Targeted for sixth week of development cycle labels Nov 24, 2021
@kflynn kflynn mentioned this issue Nov 30, 2021
Merged
4 tasks
@kflynn
Copy link
Member Author

kflynn commented Dec 1, 2021

Fixed by #3949.

@khussey
Copy link
Contributor

khussey commented Dec 16, 2021

This was fixed in Emissary-ingress 2.1.0, which is now available.

@khussey khussey closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kflynn kflynn

Labels
t:bug Something isn't working w:6 Targeted for sixth week of development cycle
Projects
None yet
Milestone
2021 Cycle 7
Development

No branches or pull requests
2 participants
@khussey @kflynn