Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy lightstep option propagation_modes not supported #3905

Closed
rbtcollins opened this issue Nov 3, 2021 · 0 comments · Fixed by #4179
Closed

Envoy lightstep option propagation_modes not supported #3905

rbtcollins opened this issue Nov 3, 2021 · 0 comments · Fixed by #4179

Comments

@rbtcollins
Copy link

Please describe your use case / problem.

The default in Envoy for tracing propagation headers is X-Ot-Span-Context. Using Envoy directly it is possible to change to different propagation_modes. We'd like to standardise on one of the standardised carriers defined in opentelemetry: for instance (and specifically for us) the W3C TraceContext headers - https://opentelemetry.io/docs/go/instrumentation/#propagators-and-context - e.g. OTEL_PROPAGATORS="tracecontext" in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md#global-propagators specifies a default of TraceContext + Baggage.

Currently we pay a cost of integration because Emissary's default is different to that in language toolkits and frameworks.

Describe the solution you'd like
Support the Envoy API for changing propagation method. Supporting the set-of-several approach that the underlying API supports would permit us to gracefully migrate across without a flag moment.

Describe alternatives you've considered
Shifting Emissary's default to be TraceContext for tracing drivers that support it would be nice too, but isn't the core concern.

Additional context
Add any other context about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant