-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose rate_limited_as_resource_exhausted in Ambassador configuration #3016
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hate to necro this thread but... is there still no way to do this?
|
@pwen , @OmegaVVeapon , there's a resolution for this in the next release. Thanks for the contribution @jeromefroe! |
This was addressed in 3.8.2. Please let us know if issues persist. |
Please describe your use case / problem.
We've configured Ambassador to send rate limit requests to a 3rd party service, and noticed that all 429 HTTP responses code are translated to
UNAVAILABLE
, as per gRPC mapping document. This isn't particularly helpful. Per Google's recommendation, 429 response shall be translated toRESOURCE_EXHAUSTED
.Envoy added the support to explicitly specify whether we want 429 responses to be mapped to
RESOURCE_EXHAUSTED
whileUNAVAILABLE
remains default; this is configurable through a flag namedrate_limited_as_resource_exhausted
.It doesn't seem like Ambassador supports this configuration.
Describe the solution you'd like
We'd like Envoy option
rate_limited_as_resource_exhausted
to be exposed via Ambassador configuration.Describe alternatives you've considered
Not at this moment.
Additional context
Reference:
The text was updated successfully, but these errors were encountered: