Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose rate_limited_as_resource_exhausted in Ambassador configuration #3016

Closed
pwen opened this issue Oct 12, 2020 · 4 comments
Closed

Expose rate_limited_as_resource_exhausted in Ambassador configuration #3016

pwen opened this issue Oct 12, 2020 · 4 comments

Comments

@pwen
Copy link

pwen commented Oct 12, 2020

Please describe your use case / problem.

We've configured Ambassador to send rate limit requests to a 3rd party service, and noticed that all 429 HTTP responses code are translated to UNAVAILABLE, as per gRPC mapping document. This isn't particularly helpful. Per Google's recommendation, 429 response shall be translated to RESOURCE_EXHAUSTED.

Envoy added the support to explicitly specify whether we want 429 responses to be mapped to RESOURCE_EXHAUSTED while UNAVAILABLE remains default; this is configurable through a flag named rate_limited_as_resource_exhausted.

It doesn't seem like Ambassador supports this configuration.

Describe the solution you'd like

We'd like Envoy option rate_limited_as_resource_exhausted to be exposed via Ambassador configuration.

Describe alternatives you've considered
Not at this moment.

Additional context
Reference:

@stale
Copy link

stale bot commented Dec 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Dec 12, 2020
@OmegaVVeapon
Copy link
Contributor

Hate to necro this thread but... is there still no way to do this?

UNAVAILABLE gRPC status codes for rate-limited responses isn't cutting it for us...

@cindymullins-dw
Copy link
Contributor

@pwen , @OmegaVVeapon , there's a resolution for this in the next release. Thanks for the contribution @jeromefroe!

@cindymullins-dw
Copy link
Contributor

This was addressed in 3.8.2. Please let us know if issues persist.

@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
@dosubot dosubot bot removed the stale Issue is stale and will be closed label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants