Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The program screen flickers (shakes) when resizing. #4070

Closed
rustbasic opened this issue Feb 19, 2024 · 10 comments
Closed

The program screen flickers (shakes) when resizing. #4070

rustbasic opened this issue Feb 19, 2024 · 10 comments
Labels
bug Something is broken

Comments

@rustbasic
Copy link
Contributor

rustbasic commented Feb 19, 2024

The program screen flickers (shakes) when resizing.

OS: Windows 10
egui Version : ALL, master

@rustbasic rustbasic added the bug Something is broken label Feb 19, 2024
@rustbasic rustbasic changed the title Shaking when Resize The program (viewport) screen shakes when resizing Feb 19, 2024
@rustbasic rustbasic changed the title The program (viewport) screen shakes when resizing The program screen flickers when resizing. Feb 19, 2024
@rustbasic rustbasic changed the title The program screen flickers when resizing. The program screen flickers (shakes) when resizing. Feb 20, 2024
@jk-gan
Copy link

jk-gan commented Jul 4, 2024

Hi @rustbasic , I saw you created a PR to fix this, may I know what is the status of this? I still getting this in empty eframe_template project. This is the latest 0.28 version.

Screen.Recording.2024-07-04.at.7.54.45.PM.2.mov

@rustbasic
Copy link
Contributor Author

Hi @rustbasic , I saw you created a PR to fix this, may I know what is the status of this? I still getting this in empty eframe_template project. This is the latest 0.28 version.

The Pull Request I created was not accepted. Next time,
I will rewrite the Pull Request that only addresses this part.

@jk-gan
Copy link

jk-gan commented Jul 4, 2024

Got it.

@jk-gan
Copy link

jk-gan commented Jul 4, 2024

Btw, I notice the screen no longer flicker when using wgpu 🤔

@rustbasic
Copy link
Contributor Author

When using wgpu, it flickers.
When using glow, it doesn't flickers.

After checking, wgpu itself enlarges/reduces the contents when resizing, so you need to provide a function in wgpu to make it not flickers.
Currently, it seems that wgpu doesn't have a function to not enlarge/reduce the contents when resizing the window.

@d3bgger
Copy link

d3bgger commented Nov 1, 2024

Seeing that this issue was closed gfx-rs/wgpu#6158 and not being addressed from wgpu side, is there any update to this from egui side?

@rustbasic
Copy link
Contributor Author

Seeing that this issue was closed gfx-rs/wgpu#6158 and not being addressed from wgpu side, is there any update to this from egui side?

I briefly checked if this issue could be easily resolved, but it seems like it's not a simple one.
I mainly use glow, so I don't have time to fix the wgpu issue.
It seems like no one has a plan to solve this yet.

Using glow in egui works without any problems.

@rustbasic
Copy link
Contributor Author

I mainly use glow, so I don't have time to fix the wgpu issue.

It would be great if someone could fix this. I'm going to close it for now.

@d3bgger
Copy link

d3bgger commented Nov 2, 2024

Thanks for the update. But why close it and not keep it open until fixed? Maybe someone wants to pick it up (maybe I can try when I am more familiar).

@rustbasic
Copy link
Contributor Author

Thanks for the update. But why close it and not keep it open until fixed? Maybe someone wants to pick it up (maybe I can try when I am more familiar).

This has been open for a long time.
I closed it because if I leave it open, you might think I'm working on solving it.
It's okay if you open it again with the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
3 participants