Skip to content
This repository has been archived by the owner on Oct 25, 2021. It is now read-only.

Check format & modifier #12

Open
emersion opened this issue Sep 8, 2019 · 3 comments
Open

Check format & modifier #12

emersion opened this issue Sep 8, 2019 · 3 comments
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@emersion
Copy link
Owner

emersion commented Sep 8, 2019

Before trying an atomic test commit, check the format & modifier is compatible.

It's not clear it's a good idea yet: all we get is a FB ID. We can drmModeGetFB it, but then we don't save an ioctl. If we cache the info, it may become out-of-date (e.g. FB deleted and re-created with another format).

Maybe we can just get the format/modifier from the library user. Need to check whether that would really improve performance though.

@emersion emersion added enhancement New feature or request question Further information is requested labels Sep 8, 2019
@emersion
Copy link
Owner Author

but then we don't save an ioctl

Actually, if we only drmModeGetFB once at the beginning of the plane alloc (or lazily), then we could save multiple atomic test commits.

@emersion
Copy link
Owner Author

emersion commented Oct 11, 2019

Unfortunately drmModeGetFB doesn't provide the format/modifier. We'll need to get it from the compositor (liftoff_layer_set_fb?), which we may have ended up doing anyway to avoid getting from the kernel information owned by the compositor itself.

@emersion
Copy link
Owner Author

There's a patch for getFB2: https://patchwork.freedesktop.org/patch/334263/?series=67552&rev=1

Still not sure it's a good idea to use it.

@emersion emersion added this to the MVP milestone Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant