re-enable watch tests #2126
re-enable watch tests #2126
Conversation
mansona
force-pushed
the
watch-tests
branch
from
910fe3b to
6c835af
Compare
mansona
force-pushed
the
watch-tests
branch
from
6c835af to
f14f3b8
Compare
mansona
force-pushed
the
watch-tests
branch
from
f14f3b8 to
4f70b3b
Compare
|
Maybe using something like virtual pair component for template only would help to reduce code in the hbs plugin and then it would probably be easier to support hmr. |
|
@mansona I fixed the particular tests that we were looking at. There are other tests that need cleanup now. For example "Scenario 4" is assuming that it will see a fresh app, but the command watcher is shared between tests, so it's initial condition fails because hello-world.js already exists from another test. |
| } | ||
|
|
||
| // we should be able to clear any earlier meta by returning | ||
| // resolution.meta here, but vite breaks that rollup feature. |
There was a problem hiding this comment.
Just use own cache then?
MetaCache = new Map();
And set the value for the id in the resolveId
There was a problem hiding this comment.
We could but this is working now. I checked and the rollup docs say it's OK to mutate the meta object that comes back from getModuleInfo().meta.
|
@ef4 I looked at the tests and I think its missing the case |
# Conflicts: # packages/vite/src/hbs.ts
This PR now updates the watch tests so they work as expected in the setup, but there is still a problem. I think we've identified a regression that will need to be fixed 🤔
Fixes: embroider-build/app-blueprint#22