Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon tests fail with scenario ember-release (3.27+) #809

Closed
NullVoxPopuli opened this issue May 12, 2021 · 3 comments
Closed

Addon tests fail with scenario ember-release (3.27+) #809

NullVoxPopuli opened this issue May 12, 2021 · 3 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

❯ node_modules/.bin/ember try:one ember-release --- ember s -p 4202
Command run: ember s -p 4202
┌────────────────────┬────────────────────┬──────────────────────────────┬──────────┐
│ Dependency         │ Expected           │ Used                         │ Type     │
├────────────────────┼────────────────────┼──────────────────────────────┼──────────┤
│ ember-source       │ https://s3.amazon… │ 3.27.0-release+67805220      │ npm      │
└────────────────────┴────────────────────┴──────────────────────────────┴──────────┘

Results in a build error:

Cannot find module '@embroider/shared-internals'
Require stack:
- /home/me/Development/NullVoxPopuli/ember-statechart-component/node_modules/@embroider/core/src/babel-plugin-adjust-imports.js
- /home/me/Development/NullVoxPopuli/ember-statechart-component/node_modules/@embroider/core/src/template-compiler-node.js
- /home/me/Development/NullVoxPopuli/ember-statechart-component/node_modules/@embroider/core/src/index.js
- /home/me/Development/NullVoxPopuli/ember-statechart-component/node_modules/ember-auto-import/js/webpack.js
- /home/me/Development/NullVoxPopuli/ember-statechart-component/node_modules/ember-auto-import/js/bundler.js
- /home/me/Development/NullVoxPopuli/ember-statechart-component/node_modules/ember-auto-import/js/auto-import.js
@ef4
Copy link
Contributor

ef4 commented May 12, 2021

Yes, I've been investigating this. It's not actually an ember-source change that broke this, because that exact same build was passing before. I think the problem was introduced by ember-cli-babel 7.26.5.

@ef4
Copy link
Contributor

ef4 commented May 12, 2021

emberjs/ember-cli-babel#402

@rwjblue
Copy link
Collaborator

rwjblue commented May 19, 2021

Fixed by emberjs/ember-cli-babel#407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants