Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vite] @embroider/virtual/vendor.js is not covered properly by Vite asset handling #2189

Open
simonihmig opened this issue Nov 29, 2024 · 0 comments · May be fixed by #2046
Open

[Vite] @embroider/virtual/vendor.js is not covered properly by Vite asset handling #2189

simonihmig opened this issue Nov 29, 2024 · 0 comments · May be fixed by #2046

Comments

@simonihmig
Copy link
Collaborator

The <script src="/@embroider/virtual/vendor.js"></script> in the source index.html is not properly converted in the output dist/index.jtml. As other assets, in a production build it should get fingerprinted and take base into account. Not doing so makes this break production deployments.

Expected

With a base of https://cdn.example.com/:

<script src="https://cdn.example.com/@embroider/virtual/vendor-Dx01Zf34.js"></script>

Actual

<script src="/@embroider/virtual/vendor.js"></script>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant