From 071fee93ad220d8fc853c85690befa502c862873 Mon Sep 17 00:00:00 2001 From: Edward Faulkner Date: Tue, 14 Nov 2023 10:06:01 -0500 Subject: [PATCH] Fix html clearing on rebuild There was a regression in #1605 that broke html clearing on rebuilds, which would cause all assets to get duplicated in the DOM. (After `removeChild(target)`, `target.nextSibling` goes undefined.) Fixes #1660. --- packages/core/src/ember-html.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/core/src/ember-html.ts b/packages/core/src/ember-html.ts index 324adeea1..99108a9a8 100644 --- a/packages/core/src/ember-html.ts +++ b/packages/core/src/ember-html.ts @@ -62,11 +62,8 @@ class Placeholder { clear() { let { start, end, parent } = this; - let target = start.nextSibling; - - while (target && target !== end) { - parent.removeChild(target); - target = target.nextSibling; + while (start.nextSibling && start.nextSibling !== end) { + parent.removeChild(start.nextSibling); } }