Renamed modules support #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very similar to the existing aliasing feature. Previously, aliasing happened both during our analysis to decide which imports to handle and then again inside webpack. Now we handle it all once during analysis and emit imports for webpack that are already aliased. This means webpack doesn't need to learn about how renamed-modules too, which don't perfectly follow aliasing rules.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 addons are allowed to declare in their package.json that they offer
renamed-modulesfor backward compatibility. For example, when we switch ember-source to publish as V2 these names should be available directly through ember-auto-import.Embroider uses
renamed-modulesextensively when auto-upgrading addons, but ember-auto-import doesn't support it yet. This PR will add it.