Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add reverted app startup changes #1964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Feb 27, 2025

Goal

Add back all the app startup changes that were reverted before 7.2 was cut

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (1199365) to head (44c1642).

Files with missing lines Patch % Lines
...rnal/session/lifecycle/ActivityLifecycleTracker.kt 0.00% 1 Missing ⚠️
...internal/capture/startup/AppStartupTraceEmitter.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
- Coverage   85.27%   85.25%   -0.03%     
==========================================
  Files         483      482       -1     
  Lines       11261    11235      -26     
  Branches     1689     1681       -8     
==========================================
- Hits         9603     9578      -25     
- Misses        905      906       +1     
+ Partials      753      751       -2     
Files with missing lines Coverage Δ
...id/embracesdk/internal/registry/ServiceRegistry.kt 100.00% <ø> (ø)
...nternal/capture/startup/AppStartupDataCollector.kt 85.71% <100.00%> (+1.09%) ⬆️
...racesdk/internal/capture/startup/StartupTracker.kt 91.48% <100.00%> (+1.01%) ⬆️
...cesdk/internal/injection/ModuleInitBootstrapper.kt 90.25% <ø> (-0.04%) ⬇️
...rnal/session/lifecycle/ActivityLifecycleTracker.kt 89.47% <0.00%> (-1.84%) ⬇️
...internal/capture/startup/AppStartupTraceEmitter.kt 81.81% <66.66%> (-0.21%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant