Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start app start up root span early to detect terminations #1944

Open
wants to merge 1 commit into
base: hho/reverted-startup-chnages
Choose a base branch
from

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Feb 24, 2025

Goal

Start the startup span as soon as it's reasonable that any terminations during it can result in it being captured as having failed.

Testing

Rely on existing tests for now to ensure there are no regressions. Additional tests will be added later to check for in-process termination when we're able to allow the finish to be triggered manaually

Copy link
Contributor

github-actions bot commented Feb 24, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Collaborator Author

bidetofevil commented Feb 24, 2025

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 76.36364% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (44c1642) to head (2e79bb4).

Files with missing lines Patch % Lines
...internal/capture/startup/AppStartupTraceEmitter.kt 75.92% 3 Missing and 10 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           hho/reverted-startup-chnages    #1944      +/-   ##
================================================================
- Coverage                         85.25%   85.24%   -0.01%     
================================================================
  Files                               482      482              
  Lines                             11235    11221      -14     
  Branches                           1681     1682       +1     
================================================================
- Hits                               9578     9565      -13     
- Misses                              906      909       +3     
+ Partials                            751      747       -4     
Files with missing lines Coverage Δ
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt 90.90% <100.00%> (+0.05%) ⬆️
...mbracesdk/internal/spans/PersistableEmbraceSpan.kt 100.00% <ø> (ø)
...internal/capture/startup/AppStartupTraceEmitter.kt 81.96% <75.92%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

@bidetofevil bidetofevil marked this pull request as ready for review February 25, 2025 15:40
@bidetofevil bidetofevil requested a review from a team as a code owner February 25, 2025 15:40
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

bidetofevil commented Feb 26, 2025

Merge activity

  • Feb 26, 10:34 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 26, 10:34 AM EST: Graphite rebased this pull request as part of a merge.
  • Feb 26, 11:06 AM EST: Graphite rebased this pull request as part of a merge.
  • Feb 26, 11:40 AM EST: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'gradle-test').

@bidetofevil bidetofevil force-pushed the hho/start-app-startup-span branch 2 times, most recently from 3483b45 to dc37ab5 Compare February 26, 2025 16:04
@bidetofevil bidetofevil force-pushed the hho/start-app-startup-span branch 2 times, most recently from 7c2ba06 to 75bf69a Compare February 26, 2025 17:50
@bidetofevil bidetofevil force-pushed the hho/start-app-startup-span branch from 75bf69a to 691af55 Compare February 27, 2025 15:41
@bidetofevil bidetofevil changed the base branch from main to graphite-base/1944 February 27, 2025 18:25
@bidetofevil bidetofevil force-pushed the hho/start-app-startup-span branch from 691af55 to 2e79bb4 Compare February 27, 2025 18:25
@bidetofevil bidetofevil changed the base branch from graphite-base/1944 to hho/reverted-startup-chnages February 27, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants