-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start app start up root span early to detect terminations #1944
base: hho/reverted-startup-chnages
Are you sure you want to change the base?
Start app start up root span early to detect terminations #1944
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hho/reverted-startup-chnages #1944 +/- ##
================================================================
- Coverage 85.25% 85.24% -0.01%
================================================================
Files 482 482
Lines 11235 11221 -14
Branches 1681 1682 +1
================================================================
- Hits 9578 9565 -13
- Misses 906 909 +3
+ Partials 751 747 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
3483b45
to
dc37ab5
Compare
7c2ba06
to
75bf69a
Compare
75bf69a
to
691af55
Compare
691af55
to
2e79bb4
Compare
Goal
Start the startup span as soon as it's reasonable that any terminations during it can result in it being captured as having failed.
Testing
Rely on existing tests for now to ensure there are no regressions. Additional tests will be added later to check for in-process termination when we're able to allow the finish to be triggered manaually