Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove relationship assertion when loading includes #81

Closed
samselikoff opened this issue Jun 18, 2019 · 1 comment
Closed

Remove relationship assertion when loading includes #81

samselikoff opened this issue Jun 18, 2019 · 1 comment
Labels
Bug

Comments

@samselikoff
Copy link
Contributor

Because of polymorphism, we cannot assert a relationship is defined when comparing a graph of data with an includes string.

Simple reproduction will be GET /things?include=author, which returns two objects in the array, one of type article which has an author: belongsTo() relationship and one of type announcement which has no author relationship.
@ryanto
Copy link
Member

ryanto commented Jun 25, 2019

#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanto @samselikoff