Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Function.prototype.on, Function.prototype.property, Function.prototype.observes #272

Merged
merged 6 commits into from
Jan 11, 2019
Merged

Deprecate Function.prototype.on, Function.prototype.property, Function.prototype.observes #272

merged 6 commits into from
Jan 11, 2019

Conversation

sarupbanskota
Copy link
Contributor

@sarupbanskota sarupbanskota commented Nov 20, 2017 •
edited
Loading

Attempts to introduce #271 to existing RFCs.

@locks locks self-assigned this Jan 3, 2018
@dfreeman dfreeman mentioned this pull request Jan 26, 2018
Closed
@rwjblue
Copy link
Member

rwjblue commented Feb 10, 2018

@sarupbanskota / @locks - Where are we will this one? Ready for more review?

@locks
Copy link
Contributor

locks commented Feb 10, 2018

@rwjblue yessir, I'm getting round to it myself

@locks locks changed the title WIP - deprecate function.prototype.{on, property, observes} Deprecate function.prototype.{on, property, observes} Feb 12, 2018
@locks locks changed the title Deprecate function.prototype.{on, property, observes} Deprecate function.prototype.{on,property,observes} Feb 12, 2018
locks
locks previously requested changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left you a suggestion to move some content around to make the RFC clearer for implementers of the deprecations and authors of the deprecation guide.

text/000-deprecation-native-function-prototype-extensions.md Outdated Show resolved Hide resolved
text/000-deprecation-native-function-prototype-extensions.md Outdated Show resolved Hide resolved
text/000-deprecation-native-function-prototype-extensions.md Outdated Show resolved Hide resolved
@sarupbanskota
Copy link
Contributor Author

@locks just updated a bit more - I think the Transition Path could use more content, but what do you think of the other pieces?

@locks locks changed the title Deprecate function.prototype.{on,property,observes} Deprecate Function.prototype.on, Function.prototype.property, Function.prototype.observes Feb 20, 2018
@locks locks dismissed their stale review February 20, 2018 09:34

points addressed

@locks locks added T-deprecation T-framework RFCs that impact the ember.js library labels Sep 18, 2018
@rwjblue
Copy link
Member

rwjblue commented Oct 7, 2018

Just did another review here, and it looks good to me. Going to bring this up at the next meeting to discuss...

@rwjblue rwjblue self-assigned this Oct 7, 2018
@tomdale
Copy link
Member

tomdale commented Dec 21, 2018

@sarupbanskota Thank you for the excellent RFC! We discussed this at the core team meeting and we had consensus that we would like to merge this RFC. This is now entering Final Comment Period, and will be merged in one week unless new substantive concerns are raised in that time.

@rwjblue
Copy link
Member

rwjblue commented Jan 11, 2019

🎉

@rwjblue rwjblue merged commit 6fbf3d3 into emberjs:master Jan 11, 2019
@kategengler kategengler mentioned this pull request Feb 12, 2019
Closed
5 tasks
@rwjblue rwjblue mentioned this pull request Apr 12, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks left review comments

Assignees

@rwjblue rwjblue

@locks locks

Labels
Final Comment Period T-deprecation T-framework RFCs that impact the ember.js library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarupbanskota @rwjblue @locks @tomdale