Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] root.loading state should be considered empty #359

Closed
runspired opened this issue Aug 17, 2018 · 1 comment
Closed

[FEAT] root.loading state should be considered empty #359

runspired opened this issue Aug 17, 2018 · 1 comment
Labels
T-ember-data RFCs that impact the ember-data library

Comments

@runspired
Copy link
Contributor

Records that have never been loaded previously transition into the root.loading state which is not considered empty. However, they have no data yet. This RFC would propose the following:

  • For records that do not preload we would transition to root.loading.empty which would set isEmpty: true
  • For records that preload we would transition to root.loading.preloaded which would not set isEmpty: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-ember-data RFCs that impact the ember-data library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ON_HOLD] feat: add additional state-machine states to handle unload/loading edge cases emberjs/data
1 participant
@runspired