Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore unique history location state #227

Closed
courajs opened this issue May 10, 2017 · 3 comments
Closed

Restore unique history location state #227

courajs opened this issue May 10, 2017 · 3 comments

Comments

@courajs
Copy link

courajs commented May 10, 2017

RFC #186 introduced per-history-entry unique ids to the HistoryLocation.

But currently on app boot, a new uuid is always generated. This means that when refreshing the page, the same history entry is given a new uuid.

Instead I think we should check history.state for existing state information, and use that if it's available. This would allow an addon to restore things such as scroll position, in line with the motivation of the original RFC.

I believe this would be a fairly straightforward change here, which I'd be happy to work on if no one sees any issues.

@stefanpenner
Copy link
Member

this may be considered a bugfix and not require an RFC?

@courajs
Copy link
Author

courajs commented May 10, 2017

I just brought it up here since it wasn't specified in the original RFC. I'm happy to move it!

@courajs
Copy link
Author

courajs commented May 10, 2017

Bugfix PR opened: emberjs/ember.js#15223

@courajs courajs closed this as completed May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants