Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10-20% performance regression between 5.9 and 5.10 #20719

Open
davidtaylorhq opened this issue Jul 9, 2024 · 2 comments
Open

10-20% performance regression between 5.9 and 5.10 #20719

davidtaylorhq opened this issue Jul 9, 2024 · 2 comments

Comments

@davidtaylorhq
Copy link

🐞 Describe the Bug

emberperf (https://emberperf.discourse.org/, https://github.com/discourse/ember-performance) has identified a performance regression between Ember 5.9 and 5.10. This is in addition to the earlier (and more significant) glimmer-vm regression being tracked in glimmerjs/glimmer-vm#1590.

reg1

Running against individual commits between 5.9 and 5.10 shows:

reg2

This suggests that the performance regression was introduced in 53b2de8 (cc @ef4)

🔬 Minimal Reproduction

Released ember versions can be tested at https://emberperf.discourse.org/. Enable the "Render Complex List (Glimmer)" test, and choose Ember versions to test.

The version of emberperf with per-commit tests can be found at discourse/ember-performance#7

@davidtaylorhq davidtaylorhq changed the title 10% performance regression between 5.9 and 5.10 10-20% performance regression between 5.9 and 5.10 Jul 9, 2024
@ef4
Copy link
Contributor

ef4 commented Jul 9, 2024

I'll take a look.

(My first impression of the benchmarking suite: it sure is tied to the non-ES-modules way of doing things that we're trying to deprecate.)

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Sep 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants