-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_debugContainerKey should be a hash that has more contextual data #10742
Comments
someone should flesh this out as an RFC |
The Ember Inspector uses this. It's a breaking change, I should update it to support the new format before/when we commit this change. The inspector would also benefit from this since we're currently parsing the value ourselves 👍 |
I am also in favor, but it will need to be done behind a feature flag to help us ensure that all tooling is ready to go. I do not think this needs to be an RFC, since it will still be considered private API (and is underscored as such already). |
Private but used by ED |
I know this property is internal but it has been so handy to leverage for two items in the app I work on:
In both of these cases the extra data in the hash might be useful 👍 |
I agree, @teddyzeenny / @wycats / any objections to this? |
I am in favor and do not mind making this a public API if fleshed out. |
👍 |
Any news on this? |
@fpauser - Not really, I think we all generally agree that there is a public API we could make out of this, but it needs to be fleshed out in an RFC and I don't think anyone has had time... |
Features are generally discussed in the https://github.com/emberjs/rfcs/ repository. You can create an issue there for feature requests or a pull request to propose a new feature. I'm closing this issue (this isn't really a bug in the framework). If someone has the time please follow up with an RFC issue/PR. |
Something like
This would enable ED to get rid of typeKey and just look up the
modelName
through the_debugContainerKey
cc @stefanpenner @fivetanley
The text was updated successfully, but these errors were encountered: