-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v3 API to README. #293
Comments
Is this mainly the switch to using promises? #292 I'm still early in the learning process of Ember app testing but would be willing to give this a shot. |
@jacobq The new testing approach is documented on guides at this point (currently at https://guides.emberjs.com/v2.18.0/testing/acceptance/ but once I'm finished with a deploy here, 2.18 won't have it documented but https://guides.emberjs.com/v3.0.0/testing/acceptance/ will) |
@acorncom OK, I was wondering about that. I'll keep working my way through the guide pages on testing and will plan to start a PR with the readme changes here after the 3.0 guides are up. |
@jacobq K, 3.0 release is up, would love to hear if you hit any snags on the latest testing info there 😀 |
@acorncom Could you help me understand what It looks to me like RFC268 says |
@jacobq I believe your reading of that RFC is accurate. When I check the latest app blueprints, it looks like we now use |
there should not be any "global helpers" anymore. if you require any helper functions you should explicitly import them instead of using the |
@Turbo87, OK, but then why does import { registerAsyncHelper } from '@ember/test';
export default registerAsyncHelper('someHelper', function(app) {
}); |
because there is no such thing as a "test-helper" anymore and that blueprint should be deleted IMHO |
Fixed by #320 |
The new
setupTest
/setupRenderingTest
API's need to be documented in the README. The existingmoduleFor*
API's should continue to be listed, but be less prominent.The text was updated successfully, but these errors were encountered: