Async method selector resolves immediately

[danfinlay]

Seem to have revealed a weird behavior regarding async helper selector resolution order. Not sure if I'm observing this right, but this is what it seems:

If I have a button that reveals another button, let's say something like:

<button class="reveal" {{action 'revealOtherButton'}}>Reveal!</button>
{{#if isRevealed}}
  <button class="special" {{action 'doImportantThings'}}>Do it!</button>
{{/if}}

And in my tests I say

click('.reveal');
click('.special');

I get an error, that .special was not found.

However, if I wrap that second click in an andThen helper, it works.

click('.reveal');
andThen(function(){
  click('.special');
});

This implies to me that the selectors are resolved immediately, while the actions are resolved asynchronously. This seems wrong to me. I would expect the selectors to resolve as part of the async action, so I can click a selector that isn't revealed yet, as long as it's after an async helper that would reveal it.

Am I reading this right? Is this deliberate behavior? If so, I would argue it's wrong.

[stefanpenner]

the async that is caused by click is likely not handled by the route.

[danfinlay]

You're right, it's handled by the controller. Are you saying that the async helpers only wait for route-level async actions?

[danfinlay]

I thought they just wait for the run loop to empty, so any Ember-run managed async action. I thought this included any controller async actions.

Is there a good reason for this? Why not wait for controller-level async?

[stefanpenner]

ou're right, it's handled by the controller. Are you saying that the async helpers only wait for route-level async actions?

correct.

[stefanpenner]

this also isn't part of ember-qunit rather ember-testing

[danfinlay]

But why not just wait for the full run loop's completion, including actions?

[danfinlay]

where is the ember-testing repo?

[stefanpenner]

@FlySwatter its part of ember