From 7ed7789071e1ab6df60f5b33a5d914addc48734d Mon Sep 17 00:00:00 2001 From: patricklx Date: Thu, 12 Dec 2019 17:08:21 +0100 Subject: [PATCH 1/2] fix issue with ember tracking reentry assert this causes: Assertion Failed: You attempted to update `[]` on `[object Object]`, but it had already been used previously in the same computation --- ember_debug/deprecation-debug.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ember_debug/deprecation-debug.js b/ember_debug/deprecation-debug.js index 0efd289e21..3d45b646b3 100644 --- a/ember_debug/deprecation-debug.js +++ b/ember_debug/deprecation-debug.js @@ -206,7 +206,7 @@ export default EmberObject.extend(PortMixin, { // For ember-debug testing we usually don't want // to catch deprecations if (!this.get('namespace').IGNORE_DEPRECATIONS) { - this.get('deprecationsToSend').pushObject(deprecation); + this.get('deprecationsToSend').push(deprecation); run.cancel(this.debounce); if (this._watching) { this.debounce = run.debounce(this, 'sendPending', 100); From 5e409a732e708a75998ef9c97be8228f294decb3 Mon Sep 17 00:00:00 2001 From: patricklx Date: Tue, 17 Dec 2019 10:27:18 +0100 Subject: [PATCH 2/2] use suggestion Co-Authored-By: Chris Garrett --- ember_debug/deprecation-debug.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ember_debug/deprecation-debug.js b/ember_debug/deprecation-debug.js index 3d45b646b3..b7a630dd95 100644 --- a/ember_debug/deprecation-debug.js +++ b/ember_debug/deprecation-debug.js @@ -206,7 +206,7 @@ export default EmberObject.extend(PortMixin, { // For ember-debug testing we usually don't want // to catch deprecations if (!this.get('namespace').IGNORE_DEPRECATIONS) { - this.get('deprecationsToSend').push(deprecation); + this.deprecationsToSend.pushObject(deprecation); run.cancel(this.debounce); if (this._watching) { this.debounce = run.debounce(this, 'sendPending', 100);