Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table's area sizing issue #892

Closed
lifeart opened this issue Dec 10, 2018 · 7 comments
Closed

Table's area sizing issue #892

lifeart opened this issue Dec 10, 2018 · 7 comments
Assignees
Labels

Comments

@lifeart
Copy link
Contributor

lifeart commented Dec 10, 2018

version:
image

issues:

image

image

image

Tables has 1/2 of available height.

Data & Components tabs looks good:
image

image

@RobbieTheWagner
Copy link
Member

I think we should be able to fix this by using ember-table for all the tables. Will try to get to that soon.

@RobbieTheWagner
Copy link
Member

@nummi since we are stuck on the ember-table stuff for now, is there something we can do to make sure the tables size correctly for now?

@nummi
Copy link
Collaborator

nummi commented Jan 5, 2019

I will take a stab at it. Do we have a consistent way of reproducing the bug?

@lifeart
Copy link
Contributor Author

lifeart commented Jan 5, 2019

@nummi yeah, try to open https://emberjs.com/api/ember/release
with Ember-inspector, having 25% size
image

after full-size it and go to routes section

image

@nummi
Copy link
Collaborator

nummi commented Jan 6, 2019

Looks like the height of the table is set manually. There is a window resize event listener that is supposed to keep it up to date but only seems to fire once. I'm not really sure why all this is necessary, shouldn't the table just take up 100% of the available height?

@lifeart
Copy link
Contributor Author

lifeart commented Jan 6, 2019

@nummi in some pages tables broken, but "Data" looks ok

@RobbieTheWagner
Copy link
Member

@nummi I think making it 100% height sounds logical. I'm not sure why it's not done like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants